Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use server API and compiler types #609

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner October 18, 2024 20:13
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.

Project coverage is 62.21%. Comparing base (1632331) to head (03a6f34).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
executor/linux/api.go 0.00% 3 Missing ⚠️
executor/local/api.go 0.00% 3 Missing ⚠️
mock/worker/executor.go 0.00% 2 Missing ⚠️
mock/worker/pipeline.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   57.51%   62.21%   +4.69%     
==========================================
  Files         121      121              
  Lines        5211     8214    +3003     
==========================================
+ Hits         2997     5110    +2113     
- Misses       1988     2878     +890     
  Partials      226      226              
Files with missing lines Coverage Δ
cmd/vela-worker/exec.go 0.00% <ø> (ø)
cmd/vela-worker/run.go 0.00% <ø> (ø)
executor/linux/build.go 76.65% <100.00%> (+4.82%) ⬆️
executor/linux/linux.go 100.00% <100.00%> (ø)
executor/linux/opts.go 100.00% <ø> (ø)
executor/linux/outputs.go 81.81% <ø> (+1.17%) ⬆️
executor/linux/secret.go 72.83% <100.00%> (-0.68%) ⬇️
executor/linux/service.go 78.94% <100.00%> (+1.70%) ⬆️
executor/linux/stage.go 77.90% <ø> (+4.63%) ⬆️
executor/linux/step.go 78.07% <100.00%> (+1.99%) ⬆️
... and 30 more

... and 60 files with indirect coverage changes

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 0e10f28 into main Oct 18, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the chore/bump-server-sdk branch October 18, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants